Skip to content

Update about-pull-requests.md #483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 15, 2020
Merged

Update about-pull-requests.md #483

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
41f942d
Update about-pull-requests.md
Ruth-ikegah Oct 13, 2020
e0856f2
Update content/github/collaborating-with-issues-and-pull-requests/abo…
Ruth-ikegah Oct 15, 2020
5c31f1a
Update content/github/collaborating-with-issues-and-pull-requests/abo…
Ruth-ikegah Oct 15, 2020
8b5c0e5
Merge branch 'main' into Ruth-ikegah/issue#430
felicitymay Oct 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update content/github/collaborating-with-issues-and-pull-requests/abo… 
…ut-pull-requests.md

Co-authored-by: Felicity Chapman <[email protected]>
  • Loading branch information
@Ruth-ikegah @felicitymay
Ruth-ikegah and felicitymay authored Oct 15, 2020
commit 5c31f1ad87ff1a83a55277d5eddb8338b09a4218
5 changes: 4 additions & 1 deletion content/github/collaborating-with-issues-and-pull-requests/about-pull-requests.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,10 @@ When you create a pull request, you can choose to create a pull request that is

### Differences between commits on compare and pull request pages

Compare pages show a compare between the tip of the head ref and the current common ancestor (i.e. merge base) of the head and base ref. On the other hand, pull request pages show a compare between the tip of the head ref and the common ancestor of the head and base ref at the time when the pull request was created. In other words, the merge base used for the comparison might be different.
The compare and pull request pages use different methods to calculate the diff for changed files:

- Compare pages show the diff between the tip of the head ref and the current common ancestor (that is, the merge base) of the head and base ref.
- Pull request pages show the diff between the tip of the head ref and the common ancestor of the head and base ref at the time when the pull request was created. Consequently, the merge base used for the comparison might be different.

### Further reading

Expand Down