Skip to content

Conversation

@jamisonhyatt
Copy link
Contributor

Why:

Context is missing around why PAT is set when fetching GH public keys for verficiationrecommend authentication or caching for secret scanning partners validating the GH pub keys.

Closes [issue link]

What's being changed:

docs for secret scanning

Check off the following:

@welcome
Copy link

welcome bot commented Apr 21, 2021

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Apr 21, 2021
@jamisonhyatt jamisonhyatt requested a review from greysteil April 21, 2021 20:54
greysteil
greysteil previously approved these changes Apr 21, 2021
Copy link
Contributor

@greysteil greysteil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we ever refer to personal access tokens as PATs in the docs, but 👍 on the content.

@janiceilene janiceilene added the secret scanning Content related to secret scanning label Apr 21, 2021
@janiceilene
Copy link
Contributor

Thanks for opening a PR with this addition @jamisonhyatt and thanks for the technical review @greysteil ⚡ I'll get this triaged for review!

@janiceilene janiceilene added waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Apr 21, 2021
schmelto
schmelto previously approved these changes Apr 22, 2021
@shati-patel shati-patel self-assigned this Apr 22, 2021
Copy link
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the change @jamisonhyatt 😃

I've added a commit to make the language/style more similar to our existing style, but I'll get this merged afterwards!

@shati-patel shati-patel added the ready to merge This pull request is ready to merge label Apr 22, 2021
@github-actions github-actions bot removed the waiting for review Issue/PR is waiting for a writer's review label Apr 22, 2021
@shati-patel shati-patel enabled auto-merge (squash) April 22, 2021 15:05
@shati-patel shati-patel merged commit 7087d25 into main Apr 22, 2021
@shati-patel shati-patel deleted the jamisonhyatt-secret-scanning-rate-cache-etag branch April 22, 2021 15:11
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge This pull request is ready to merge secret scanning Content related to secret scanning

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants