-
Notifications
You must be signed in to change notification settings - Fork 64.1k
Add rate limit note; suggest caching/etags #5614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rate limit note; suggest caching/etags #5614
Conversation
|
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if we ever refer to personal access tokens as PATs in the docs, but 👍 on the content.
|
Thanks for opening a PR with this addition @jamisonhyatt and thanks for the technical review @greysteil ⚡ I'll get this triaged for review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the change @jamisonhyatt 😃
I've added a commit to make the language/style more similar to our existing style, but I'll get this merged afterwards!
|
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Why:
Context is missing around why PAT is set when fetching GH public keys for verficiationrecommend authentication or caching for secret scanning partners validating the GH pub keys.
Closes [issue link]
What's being changed:
docs for secret scanning
Check off the following: