Skip to content

Implement an optional Stage2 interface that allows such stages to be started more flexibly #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Implement an optional Stage2 interface that allows such stages to be started more flexibly #20

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
ffae882
Shush the linter
mhagger Dec 17, 2023
95dc2e8
pipeline_test.go: get rid of a bunch of unnecessary tmpdirs
mhagger Dec 16, 2023
5fdc22a
TestPipelineStdinThatIsNeverClosed(): create stdin more simply
mhagger Dec 16, 2023
c2c9802
pipeline_test.go: use `WithStdoutCloser()` to close stdout pipes
mhagger Dec 16, 2023
f595c9e
Add some benchmarks of moving a bunch of data through a pipeline
mhagger Dec 16, 2023
385f6c7
Simplify the `NopCloser`s
mhagger Dec 15, 2023
6820dbb
Implement Stage2 with a more flexible way of starting stages
mhagger Dec 15, 2023
3462135
Add some tests that `Pipeline.Start()` picks the right stdin/stdout
mhagger Dec 17, 2023
413069f
Improve some names related to the new interface:
mhagger Aug 3, 2024
81487bf
Pipeline.Start(): initialize both stage preferences
mhagger Aug 3, 2024
585617b
Makefile: fix linting rule
mhagger Aug 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Makefile: fix linting rule
  • Loading branch information
@mhagger
mhagger committed Aug 3, 2024
commit 585617b7a39cce792b4ac5a28b1c8c817568f881
5 changes: 2 additions & 3 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,13 @@ vet:
go vet ./...

BIN := $(CURDIR)/bin
GO := GO
$(BIN):
mkdir -p $(BIN)
mkdir -p $(BIN)

# Run golang-ci lint on all source files:
GOLANGCILINT := $(BIN)/golangci-lint
$(BIN)/golangci-lint:
GOBIN=$(BIN) $(GO) install github.com/golangci/golangci-lint/cmd/golangci-lint@latest
GOBIN=$(BIN) go install github.com/golangci/golangci-lint/cmd/golangci-lint@latest

.PHONY: fmt
lint: | $(GOLANGCILINT)
Expand Down