Skip to content

Support Python 3.6+ #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
janbridley merged 27 commits into from
May 16, 2024
Merged

Support Python 3.6+ #13

Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
5413053
Add minimal setup.py
janbridley May 10, 2024
dd31f29
Switch dataclass to namedtuple
janbridley May 10, 2024
c256e69
Fix typing for python < 3.7
janbridley May 10, 2024
5384645
Split tests into two blocks
janbridley May 10, 2024
258103a
Add required workflow steps
janbridley May 10, 2024
cc4cb60
pip install -r
janbridley May 10, 2024
05393d8
Add pytest to reqs
janbridley May 10, 2024
32984ad
Rename CI features
janbridley May 10, 2024
0646b07
Properly implement workflow_call procedure
janbridley May 10, 2024
f4c5a6d
Remove incorrect runs_on key
janbridley May 10, 2024
805c151
Rename action
janbridley May 10, 2024
dccbd6d
Fix syntax in CI
janbridley May 10, 2024
1321804
Set legacy tests to run after modern versions pass
janbridley May 10, 2024
9275e93
Clean up CI script
janbridley May 10, 2024
157286c
Clean up action names
janbridley May 10, 2024
3e346fa
Parameterize runs-on
janbridley May 11, 2024
c24fc58
Add runs-on input to workflow callable
janbridley May 11, 2024
0b99c43
Move python 3.6 tests to ubuntu 20.04
janbridley May 11, 2024
4306088
Test python 3.5
janbridley May 11, 2024
266d574
Remove broken python 3.5
janbridley May 11, 2024
f939f64
Update install files
janbridley May 11, 2024
d4f3fdd
Merge branch 'main' into feature/#10-support-python-3.6
janbridley May 13, 2024
adabd29
Swapped requirements.txt with requirements.in
janbridley May 16, 2024
6ba81a6
Swapped tests requirements.txt with requirements.in
janbridley May 16, 2024
20b4554
Added legacy test requirements file
janbridley May 16, 2024
a81bb51
Fixed pin and reran pip-compile on python 3.6
janbridley May 16, 2024
9dcd291
Set default value for requirements-file
janbridley May 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add pytest to reqs
  • Loading branch information
@janbridley
janbridley committed May 10, 2024
commit 05393d88e15d066e84ef329767f1e422632d3c9b
1 change: 1 addition & 0 deletions tests/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
gemmi
pytest
Copy link
Member

@joaander joaander May 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To make CI tests more reproducible, you should pin specific versions of packages in requirements.in, then use pip-compile to generate requirements.txt that pins all transitive dependencies. That way, an update to a transitive dependency is less likely to cause CI failures from one build to the next with no changes to parsnip. Readthedocs has a nice write up: https://docs.readthedocs.io/en/stable/guides/reproducible-builds.html#pin-your-transitive-dependencies

Dependabot knows how to update requirements.in and rerun pip-compile. Add pip to the dependabot config and you will get PRs that test the updated pins: https://github.com/glotzerlab/gsd/blob/trunk-patch/.github/dependabot.yml