Support wildcards for data lookup #35
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
__getitem__,get_from_pairs, andget_from_loopsnow support "?" and "*" wildcards. This functionality is built in to python'sfnmatchmodule, which is used under the hood for these queries. The full unix-style pattern matching is not supported (specifically "[xyz]" and "[!xyz]" patterns), as cif keys commonly contain bracket characters.Motivation and Context
The
boxandlattice_vectorsproperties made an implicit assumption that files used the CIF format for the lookup keys. This assumption is no longer required, as "_cell_length_alpha" and "_cell.length_angle" can now be easily matched with "_cell?length_alpha".Types of Changes
1The change breaks (or has the potential to break) existing functionality and should be merged into the
breakingbranchChecklist: