feat(knowbase): Share article with unique URL #18751
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cedric-anne
reviewed
Jan 20, 2025
AdrienClairembault
requested changes
Jan 24, 2025
Contributor
AdrienClairembault
left a comment
AdrienClairembault
left a comment
There was a problem hiding this comment.
I think we also need some tests to be added.
AdrienClairembault
requested changes
Jan 27, 2025
Co-authored-by: Adrien Clairembault <[email protected]>
Contributor
|
Ok for me (besides tests) 👍 |
cedric-anne
requested changes
Jan 29, 2025
Comment on lines
+131
to
+132
| && isset($_GET['token']) | ||
| && hash_equals($this->fields["token"], $_GET['token']) |
Member
There was a problem hiding this comment.
I would prefer to not have to rely on $_GET here. I do not have time right now to check if we can change this, but this is clearly I want to check before validating this PR.
AdrienClairembault
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Please delete options that are not relevant.
Description
Share an article via a unique URL.
Screenshots (if appropriate):
#17488