Skip to content

fix(itil): Linked itilobject should return the child entities itilobject #21680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: 11.0/bugfixes
Choose a base branch
from
+72 −12
Open

fix(itil): Linked itilobject should return the child entities itilobject #21680

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
1879d80
fix(ui): Improve visibility of sub-entity button in the entity switch…
froozeify Oct 28, 2025
13c6fac
fix(itil): #21545 return all active entities in the case where the us…
froozeify Oct 28, 2025
f3f0ff4
fix(itil): Disable link if user don't have the read access on it
froozeify Oct 29, 2025
e9c4a6a
test(itil): Add test for new linked itilobjects + add some aria-label…
froozeify Oct 29, 2025
4fbcaee
fix(itil): Add default aria_label value for items
froozeify Oct 29, 2025
ac08664
chore(itil): make aria-label translatable
froozeify Oct 30, 2025
8bda569
test(cypress): Add missing method in select2 interface
froozeify Nov 5, 2025
72e24e1
fix(itil): Update linked itil child entities logic
froozeify Nov 5, 2025
4fbca28
Apply suggestions from code review
froozeify Nov 12, 2025
2383538
Migrate ux improvement to a dedicated PR
froozeify Nov 12, 2025
1838001
test(cypress): swith to using data-testid
froozeify Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(itil): Disable link if user don't have the read access on it
  • Loading branch information
@froozeify
froozeify committed Nov 5, 2025
commit f3f0ff43d998bc20a57ce889bb0f5029b8aaa86e
26 changes: 17 additions & 9 deletions templates/components/itilobject/linked_itilobjects.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,17 +49,25 @@
])|raw }}
</div>
<div class="col text-truncate">
<a href="{{ linked['itemtype']|itemtype_form_path(linked['items_id']) }}" class="col-9 overflow-hidden text-nowrap">
<i class="{{ linked['itemtype']|itemtype_icon }}" title="{{ linked['itemtype']|itemtype_name }}" data-bs-toggle="tootlip"></i>
{{ new_itilobject.getStatusIcon(new_itilobject.fields['status'])|raw }}
<span title="{{ new_itilobject.fields['name'] }}" data-bs-toggle="tooltip">
{{ new_itilobject.fields['name'] }}
</span>
({{ new_itilobject.fields['id'] }})
</a>
{% set _content %}
<i class="{{ linked['itemtype']|itemtype_icon }}" title="{{ linked['itemtype']|itemtype_name }}" data-bs-toggle="tootlip"></i>
{{ new_itilobject.getStatusIcon(new_itilobject.fields['status'])|raw }}
<span title="{{ new_itilobject.fields['name'] }}" data-bs-toggle="tooltip">
{{ new_itilobject.fields['name'] }}
</span>
({{ new_itilobject.fields['id'] }})
{% endset %}

{% if new_itilobject.canViewItem() %}
<a href="{{ linked['itemtype']|itemtype_form_path(linked['items_id']) }}" class="col-9 overflow-hidden text-nowrap">
{{ _content }}
</a>
{% else %}
{{ _content }}
{% endif %}
</div>

{% if canupdate %}
{% if new_itilobject.canDeleteItem() %}
<div class="col-auto">
<button type="submit"
form="linked_itilobjects_{{ main_rand }}"
Expand Down