Skip to content

Conversation

@Herafia
Copy link
Contributor

@Herafia Herafia commented Oct 30, 2025

Checklist before requesting a review

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my code.

Description

  • It fixes !39956
  • A self-service user couldn’t cancel a ticket because the cancel button was visible but not functional — the form opening was missing.

Screenshots (if appropriate):

image

@Herafia Herafia self-assigned this Oct 30, 2025
@Herafia Herafia added the bug label Oct 30, 2025
@Herafia Herafia changed the title restore form opening so cancel button works properly fix/restore form opening so cancel button works properly Oct 30, 2025
@stonebuzz
Copy link
Contributor

stonebuzz commented Nov 4, 2025

Discussed with @Herafia and @Rom1-B

We identified an issue with missing <form> tags in simplified interfaces, specifically on the "Cancel Ticket" button.

During the investigation, we found that the file templates/components/itilobject/layout.html.twig lacked clarity regarding the conditions required to display the <form> tags.

This PR aims to simplify and clarify the logic by systematically opening and closing the <form> tag when we are not within a specific template context.

Copy link
Contributor

@AdrienClairembault AdrienClairembault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it create conflicts with the new followup form.

You can't add followups anymore:

Image

@Herafia Herafia force-pushed the fix/restore-form-opening-so-cancel-button-works-properly branch from decbabd to a16ebe5 Compare November 12, 2025 10:40
@stonebuzz
Copy link
Contributor

The checkFormOutput unit test has been updated.
Going forward, the HTML page may contain either one itil_form element (when creating a new ticket) or two — one for the main form and another for objects (followup / solution / document) creation forms added by footer.

@stonebuzz
Copy link
Contributor

The checkFormOutput unit test has been updated. Going forward, the HTML page may contain either one itil_form element (when creating a new ticket) or two — one for the main form and another for objects (followup / solution / document) creation forms added by footer.

Don’t worry about this — we’re refactoring the code to properly handle unique forms, regardless of whether it’s for updating a ticket, adding a follow-up, or cancelling one, since they all point to the same front end as previously implemented

@cedric-anne cedric-anne added this to the 11.0.3 milestone Nov 13, 2025
Copy link
Contributor

@AdrienClairembault AdrienClairembault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cancel ticket button doesn't seems to work with the latest changes, nothing happen when I click on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants