fix(entity): Creating a child entity will redirect the user to an exception page #21761
+32
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
froozeify
force-pushed
the
11.0/21497-problem-with-entity-creation
branch
from
f09dba6 to
1884957
Compare
| // Root entity cannot be deleted, so if we added an entity this means GLPI is now multi-entity | ||
| $_SESSION['glpi_multientitiesmode'] = 1; | ||
| // We force the recursivity, so the new entity is visible in the current session | ||
| Session::changeActiveEntities(Session::getActiveEntity(), true); |
Contributor
There was a problem hiding this comment.
Do we need to check that the user is allowed to see recursive content?
I think the "add entity" action is only available for users that can see recursive content anyway but I guess it doesn't hurt to check twice here?
Not a mandatory change, just wondering out loud.
Member
There was a problem hiding this comment.
IMHO, we must only add the newly created entity to the active scope. The existing hack was probably incomplete, maybe only updating one or two more session variables is enough.
cedric-anne
requested changes
Nov 6, 2025
| // Root entity cannot be deleted, so if we added an entity this means GLPI is now multi-entity | ||
| $_SESSION['glpi_multientitiesmode'] = 1; | ||
| // We force the recursivity, so the new entity is visible in the current session | ||
| Session::changeActiveEntities(Session::getActiveEntity(), true); |
Member
There was a problem hiding this comment.
IMHO, we must only add the newly created entity to the active scope. The existing hack was probably incomplete, maybe only updating one or two more session variables is enough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Description
Creating a subentity the form will redirect the user to it , but since the user has activated an entity, he won't have access.
This PR is the implementation of my proposal number 3 : #21497 (comment)
Screenshots:
Screencast.from.2025-11-03.09-52-19.webm