fix: php8.5 null array warning #21769
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Issue is spotted from this PR: #21741 on v11 |
froozeify
force-pushed
the
10.0/fix-null-array-keys
branch
from
7c7a65a to
36a6fc8
Compare
Contributor
AdrienClairembault
left a comment
AdrienClairembault
left a comment
There was a problem hiding this comment.
Maybe you'll also need to migrate existing values from the database?
Member
Author
|
The empty check support null value as an empty string so I don't think the migration from the database is required. More so, the current |
AdrienClairembault
approved these changes
Nov 4, 2025
cedric-anne
approved these changes
Nov 4, 2025
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Description
PHP 8.5 trigger warnings when a null array key is set
https://github.com/glpi-project/glpi/actions/runs/19026238231/job/54330365672?pr=21741