Fix (API HL) - JOIN alias in user schema generates missing column error #21779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trasher
reviewed
Nov 4, 2025
|
This probably need a test case |
cconard96
approved these changes
Nov 4, 2025
cedric-anne
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Please delete options that are not relevant.
Description
This PR fixes a GraphQL/HL API bug causing SQL errors when querying users for users that cannot view all entities. The User schema used the physical table name in a
LEFT JOINinstead of the query table alias ('_'), which produced invalid SQL (unknown columnglpi_users.id).The change updates the JOIN to use the correct table alias so queries build valid SQL and the GraphQL User endpoint works consistently.