-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Forms: entity from requester #22267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forms: entity from requester #22267
Conversation
| // TODO: why does this field seems to support multiple stategies? | ||
| // It doesn't make sense IMO, can you take a look @ccailly? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ping @ccailly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ccailly did not respond to the ping, maybe could you @AdrienClairembault open an issue and assign him?
src/Glpi/Form/Destination/CommonITILField/EntityFieldStrategy.php
Outdated
Show resolved
Hide resolved
|
Some existing tests need to be updated since I've modified the bootstrap data, hold on I'll do it a bit later today. |
trasher
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Checklist before requesting a review
Description
Add a new configuration value for forms destinations:
This is useful when a technician is filling a form and the ticket requester is selected from the form's question:
Here, you want the ticket to be created in the entity of the user from the "Requester" question.
As you know, GLPI lack a "default" entity for a user (the "Default entity" user setting is missnamed and not fit for this purpose as we all know - it is an UX pref setting and do not represent the "main" profile assignment of a user).
So the rules to get the correct entity are:
References
Internal support ticket: !40514