Skip to content

Conversation

@hmelder
Copy link
Member

@hmelder hmelder commented Aug 23, 2022

  • Bump minimum supported version to 7.66.0 and remove old checks for quirks
  • Use pkg-config instead of curl-config, as curl-config is not installed when targeting Windows.
  • Remove gnutls warning, as no loss of functionality is observed.

@hmelder hmelder requested a review from rfm as a code owner August 23, 2022 11:04
@hmelder hmelder marked this pull request as draft August 23, 2022 11:42
Copy link
Contributor

@rfm rfm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are multiple problems with this patch breaking things.
The use of pkg-config is a last resort because it is not be available on some systems.
If we don't have curl-config to tell us about curl, we could try pkg-config as a fallback.

configure.ac Outdated
AC_CHECK_HEADERS(curl/curl.h, curl_ok=yes, curl_ok=no)

if test -n "$PKG_CONFIG"; then
if pkg-config --exists libcurl; then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't you be using $PKG_CONFIG here as well (and in line 3631)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right

@hmelder hmelder marked this pull request as ready for review August 24, 2022 13:18
@hmelder hmelder requested a review from rfm August 24, 2022 13:18
@rfm rfm merged commit a990120 into master Nov 21, 2022
@triplef triplef deleted the libcurl-autoconf branch December 21, 2022 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants