-
Notifications
You must be signed in to change notification settings - Fork 291
Rewrite autoconf libcurl detection #269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
hmelder
commented
Aug 23, 2022
- Bump minimum supported version to 7.66.0 and remove old checks for quirks
- Use pkg-config instead of curl-config, as curl-config is not installed when targeting Windows.
- Remove gnutls warning, as no loss of functionality is observed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there are multiple problems with this patch breaking things.
The use of pkg-config is a last resort because it is not be available on some systems.
If we don't have curl-config to tell us about curl, we could try pkg-config as a fallback.
configure.ac
Outdated
| AC_CHECK_HEADERS(curl/curl.h, curl_ok=yes, curl_ok=no) | ||
|
|
||
| if test -n "$PKG_CONFIG"; then | ||
| if pkg-config --exists libcurl; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't you be using $PKG_CONFIG here as well (and in line 3631)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right
… into libcurl-autoconf