Add compatibility for Swift corelibs libdispatch release #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the libdispatch runloop integration to be compatible with the Swift corelibs libdispatch release: https://github.com/apple/swift-corelibs-libdispatch In that release, the main queue handle and drain functions have been renamed with a "_4CF" (for CoreFoundation) suffix and have moved to private.h, so we now check for the existance of this header and function names. Note that libdispatch must be compiled with INSTALL_PRIVATE_HEADERS=YES. Also fixes the checks for the HAVE_LIBDISPATCH_RUNLOOP define (was inverted) and ensures that both the handle and drain functions are available.
triplef
force-pushed
the
swift-corelibs-libdispatch-compat
branch
from
7421439 to
43c5cca
Compare
|
This can also be tested using the GNUstep Android toolchain, which this patch is part of. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the libdispatch runloop integration to be compatible with Apple’s Swift corelibs libdispatch release, which to my knowledge is the most up-to-date and actively maintained release of libdispatch.
In that release, the main queue handle and drain functions have been renamed with a "_4CF" (for CoreFoundation) suffix and have moved to private.h, so we now check for the existance of this header and function names.
Note that libdispatch must be compiled with
INSTALL_PRIVATE_HEADERS=YES. Please let me know if there is a good place to document this.Also fixes the checks for the
HAVE_LIBDISPATCH_RUNLOOPdefine (was inverted) and ensures that both the handle and drain functions are available (as expected by NSRunLoop.m).