Exclude internal breakpoints from response

[ConradIrwin]

While working on debugger support for Zed, I noticed that
delve returns internal breakpoints in the "hit breakpoints" array when handling
a panic.

Although there's nothing really wrong with doing this, it caused an edge-case
in our parsing code (as in practice everyone uses unsigned integers for
breakpoint ids), and there's no particular value in doing so (because the
client has no record of the internal breakpoints).

[aarzilli]

Those aren't internal breakpoints, they just exist by default. You could delete them if you wanted (which is something people want to do #3653).

[aarzilli]

LGTM, although maybe one day we should emit breakpoint events to make clients aware of these instead.

[ConradIrwin]

@aarzilli makes sense. Is there a way as a client to know that these exist, or as a delve consumer should I just expect them to be there and expose UI to control them?

I didn't see an immediately obvious "list all breakpoints" command in the DAP, so sorry if this is just a lack of my understanding.

[aarzilli]

We'd have to emit breakpoint events ourselves and clients would have to handle them correctly (if we start doing this it would have to check that at least vscode supports it correctly).

There is no "list all breakpoints" API, you are not missing anything (or we are both missing it).

[derekparker]

LGTM