Skip to content

Make the github migration less rate limit waiting to get comment per page from repository but not per issue #16070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 30, 2021
Merged

Make the github migration less rate limit waiting to get comment per page from repository but not per issue #16070

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7e8f313
Make the github migration less rate limit waiting to get comment per …
lunny Jun 5, 2021
e6cb781
Fix lint
lunny Jun 5, 2021
1706cab
adjust Downloader interface
lunny Jun 5, 2021
5ff3335
Fix missed reviews
lunny Jun 5, 2021
ef73d4e
Fix test
lunny Jun 5, 2021
cf0b1f6
Remove unused struct
lunny Jun 5, 2021
0c8a155
Merge branch 'main' into lunny/faster_get_comment_from_github
lunny Jun 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix missed reviews
  • Loading branch information
@lunny
lunny committed Jun 14, 2021
commit 5ff3335759ab89edffaa9405f11b6de7366f0fd3
46 changes: 24 additions & 22 deletions modules/migrations/migrate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,33 +358,35 @@ func migrateRepository(downloader base.Downloader, uploader base.Uploader, opts
return err
}

if opts.Comments && !supportAllComments {
// plain comments
var allComments = make([]*base.Comment, 0, commentBatchSize)
for _, pr := range prs {
log.Trace("migrating pull request %d's comments", pr.Number)
comments, _, err := downloader.GetComments(base.GetCommentOptions{
IssueNumber: pr.Number,
})
if err != nil {
if !base.IsErrNotSupported(err) {
return err
if opts.Comments {
if !supportAllComments {
// plain comments
var allComments = make([]*base.Comment, 0, commentBatchSize)
for _, pr := range prs {
log.Trace("migrating pull request %d's comments", pr.Number)
comments, _, err := downloader.GetComments(base.GetCommentOptions{
IssueNumber: pr.Number,
})
if err != nil {
if !base.IsErrNotSupported(err) {
return err
}
log.Warn("migrating comments is not supported, ignored")
}
log.Warn("migrating comments is not supported, ignored")
}

allComments = append(allComments, comments...)
allComments = append(allComments, comments...)

if len(allComments) >= commentBatchSize {
if err = uploader.CreateComments(allComments[:commentBatchSize]...); err != nil {
return err
if len(allComments) >= commentBatchSize {
if err = uploader.CreateComments(allComments[:commentBatchSize]...); err != nil {
return err
}
allComments = allComments[commentBatchSize:]
}
allComments = allComments[commentBatchSize:]
}
}
if len(allComments) > 0 {
if err = uploader.CreateComments(allComments...); err != nil {
return err
if len(allComments) > 0 {
if err = uploader.CreateComments(allComments...); err != nil {
return err
}
}
}

Expand Down