Skip to content

Add API to get commits of PR #16300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 2, 2021
Merged

Add API to get commits of PR #16300

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8e06bb5
Add API to get commits of PR
sebastian-sauer Jun 29, 2021
8ae97b6
Merge remote-tracking branch 'origin/main' into feature/10918_commits…
sebastian-sauer Jun 30, 2021
0cc2fba
Use X-Total-Count header instead of X-Total
sebastian-sauer Jun 30, 2021
419a2a9
Merge branch 'main' into feature/10918_commits_of_pr
6543 Jun 30, 2021
77f92b3
Merge branch 'main' into feature/10918_commits_of_pr
6543 Jul 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use X-Total-Count header instead of X-Total 
as proposed in #11114

Co-authored-by: 6543 <[email protected]>
  • Loading branch information
@sebastian-sauer @6543
sebastian-sauer and 6543 authored Jun 30, 2021
commit 0cc2fba8fce1990f36c68ca4cf937717c2288149
2 changes: 1 addition & 1 deletion routers/api/v1/repo/pull.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1217,7 +1217,7 @@ func GetPullRequestCommits(ctx *context.APIContext) {

ctx.Header().Set("X-Page", strconv.Itoa(listOptions.Page))
ctx.Header().Set("X-PerPage", strconv.Itoa(listOptions.PageSize))
ctx.Header().Set("X-Total", strconv.FormatInt(int64(totalNumberOfCommits), 10))
ctx.Header().Set("X-Total-Count", fmt.Sprintf("%d", totalNumberOfCommits))
ctx.Header().Set("X-PageCount", strconv.Itoa(totalNumberOfPages))
ctx.Header().Set("X-HasMore", strconv.FormatBool(listOptions.Page < totalNumberOfPages))
ctx.JSON(http.StatusOK, &apiCommits)
Expand Down