Skip to content

Support HTTP/2 in Let's Encrypt #16371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 13, 2021
Merged

Support HTTP/2 in Let's Encrypt #16371

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7adc845
Set tlsConfig.NextProtos to h2 in order to support HTTP/2
Jul 8, 2021
b3497c1
still allow http1 too
6543 Jul 8, 2021
d3e844e
Merge branch 'main' into main
Jul 9, 2021
3903fe8
Merge branch 'go-gitea:main' into main
Jul 11, 2021
874abd4
Merge branch 'main' into main
zeripath Jul 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cmd/web_letsencrypt.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ func runLetsEncrypt(listenAddr, domain, directory, email string, m http.Handler)
}

tlsConfig := magic.TLSConfig()
tlsConfig.NextProtos = append(tlsConfig.NextProtos, "h2")

if enableHTTPChallenge {
go func() {
Expand Down
2 changes: 1 addition & 1 deletion modules/graceful/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ func (srv *Server) ListenAndServe(serve ServeFunction) error {
func (srv *Server) ListenAndServeTLS(certFile, keyFile string, serve ServeFunction) error {
config := &tls.Config{}
if config.NextProtos == nil {
config.NextProtos = []string{"http/1.1"}
config.NextProtos = []string{"h2"}
}

config.Certificates = make([]tls.Certificate, 1)
Expand Down