Skip to content

Prevent double sanitize #16386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 19, 2021
Merged

Prevent double sanitize #16386

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
49fd4b4
Prevent double sanitize.
KN4CK3R Jul 8, 2021
e5c8221
Lint
KN4CK3R Jul 9, 2021
88a48a5
Merge branch 'main' of https://github.com/go-gitea/gitea into refacto…
KN4CK3R Nov 15, 2021
49f199d
Use SanitizeReaderToWriter.
KN4CK3R Nov 16, 2021
e45e4f3
Merge branch 'main' into refactor-sanitize
lunny Nov 17, 2021
0f54645
Merge branch 'main' into refactor-sanitize
wxiaoguang Nov 18, 2021
412eb48
Merge branch 'main' into refactor-sanitize
lunny Nov 19, 2021
3eca040
Merge branch 'main' into refactor-sanitize
wxiaoguang Nov 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'main' of https://github.com/go-gitea/gitea into refacto… 
…r-sanitize
  • Loading branch information
@KN4CK3R
KN4CK3R committed Nov 15, 2021
commit 88a48a5b5f2cb609099e42af3ff086468b23d660
2 changes: 1 addition & 1 deletion modules/markup/markdown/markdown.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ func actualRender(ctx *markup.RenderContext, input io.Reader, output io.Writer)

// FIXME: Don't read all to memory, but goldmark doesn't support
Copy link
Contributor

@Gusted Gusted Nov 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cliff hanger here, reading it for the first time doesn't immediately hint me what goldmark doesn't support.

pc := newParserContext(ctx)
buf, err := ioutil.ReadAll(input)
buf, err := io.ReadAll(input)
if err != nil {
log.Error("Unable to ReadAll: %v", err)
return err
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.