Skip to content

Fix table alignment in markdown (#16596) #16602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 3, 2021
Merged

Fix table alignment in markdown (#16596) #16602

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
549b0ab
Fix table alignment in markdown (#16596)
zeripath Aug 2, 2021
55dc66a
Merge branch 'release/v1.15' into backport-16596-v1.15
zeripath Aug 3, 2021
496142d
Merge branch 'release/v1.15' into backport-16596-v1.15
lafriks Aug 3, 2021
d12066e
Merge branch 'release/v1.15' into backport-16596-v1.15
zeripath Aug 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix table alignment in markdown (#16596) 
Backport #16596

Set the TableOptions in markdown to allow alignment of the tables to work correctly

Fix #15959

Signed-off-by: Andrew Thornton <[email protected]>
  • Loading branch information
@zeripath
zeripath committed Aug 2, 2021
commit 549b0ab2c080c2961d535ee64789e0f18c6efc48
4 changes: 3 additions & 1 deletion modules/markup/markdown/markdown.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,9 @@ func newParserContext(ctx *markup.RenderContext) parser.Context {
func actualRender(ctx *markup.RenderContext, input io.Reader, output io.Writer) error {
once.Do(func() {
converter = goldmark.New(
goldmark.WithExtensions(extension.Table,
goldmark.WithExtensions(
extension.NewTable(
extension.WithTableCellAlignMethod(extension.TableCellAlignAttribute)),
extension.Strikethrough,
extension.TaskList,
extension.DefinitionList,
Expand Down