Skip to content

Improve SMTP authentication and Fix user creation bugs #16612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 11, 2021
Merged

Improve SMTP authentication and Fix user creation bugs #16612

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0924f42
Improve SMTP authentication, Fix user creation bugs and add LDAP cert…
zeripath Aug 7, 2021
e0e045a
as per lafriks
zeripath Aug 7, 2021
d44ef83
Merge branch 'main' into replace-16104-allow-different-smtp-port
zeripath Aug 11, 2021
a034c54
as per 6543
zeripath Aug 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
as per 6543 
Signed-off-by: Andrew Thornton <[email protected]>
  • Loading branch information
@zeripath
zeripath committed Aug 11, 2021
commit a034c5461e3af657b981700ab0c126db4107a8c1
9 changes: 5 additions & 4 deletions services/auth/source/smtp/source_authenticate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,13 +28,14 @@ func (source *Source) Authenticate(user *models.User, login, password string) (*
}

var auth smtp.Auth
if source.Auth == PlainAuthentication {
switch source.Auth {
case PlainAuthentication:
auth = smtp.PlainAuth("", login, password, source.Host)
} else if source.Auth == LoginAuthentication {
case LoginAuthentication:
auth = &loginAuthenticator{login, password}
} else if source.Auth == CRAMMD5Authentication {
case CRAMMD5Authentication:
auth = smtp.CRAMMD5Auth(login, password)
} else {
default:
return nil, errors.New("unsupported SMTP auth type")
}

Expand Down