Skip to content

Remove NewSession method from db.Engine interface #17577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 21, 2021
Merged

Remove NewSession method from db.Engine interface #17577

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
67ae74d
Remove NewSession method from db.Engine interface
lunny Nov 7, 2021
b2fc08a
Fix bug
lunny Nov 7, 2021
42a9c98
Some improvements
lunny Nov 13, 2021
1dc98ac
Fix bug
lunny Nov 13, 2021
ebccf6c
Fix test
lunny Nov 20, 2021
33f6a18
Use XXXBean instead of XXXExample
lunny Nov 20, 2021
ae88150
Merge branch 'main' into lunny/remove_newsession
lunny Nov 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix test
  • Loading branch information
@lunny
lunny committed Nov 21, 2021
commit ebccf6c4c0a65b534ea38efdc20da291610dbb48
2 changes: 1 addition & 1 deletion models/org.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -486,7 +486,7 @@ func GetUserOrgsList(user *User) ([]*MinimalOrg, error) {
groupByStr = groupByStr[0 : len(groupByStr)-1]

sess := db.GetEngine(db.DefaultContext)
sess.Select(groupByStr+", count(distinct repo_id) as org_count").
sess = sess.Select(groupByStr+", count(distinct repo_id) as org_count").
Table("user").
Join("INNER", "team", "`team`.org_id = `user`.id").
Join("INNER", "team_user", "`team`.id = `team_user`.team_id").
Expand Down
2 changes: 1 addition & 1 deletion models/repo.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1777,7 +1777,7 @@ func GetUserRepositories(opts *SearchRepoOptions) ([]*Repository, int64, error)
return nil, 0, fmt.Errorf("Count: %v", err)
}

sess.Where(cond).OrderBy(opts.OrderBy.String())
sess = sess.Where(cond).OrderBy(opts.OrderBy.String())
repos := make([]*Repository, 0, opts.PageSize)
return repos, count, db.SetSessionPagination(sess, opts).Find(&repos)
}
Expand Down