Skip to content

GitLab reviews may not have the updated_at field set #18450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 29, 2022
Merged

GitLab reviews may not have the updated_at field set #18450

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1e77e0a
GitLab reviews may not have the updated_at field set
Jan 29, 2022
0a4d285
use assert.WithinDuration
Jan 29, 2022
77a06f0
Update services/migrations/gitlab.go
6543 Jan 29, 2022
ca4172f
Merge branch 'main' into forgefriends-mr-37
6543 Jan 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update services/migrations/gitlab.go
  • Loading branch information
@6543
6543 authored Jan 29, 2022
commit 77a06f0d2237b8c1218b83d3dac18c4d4044ee72
6 changes: 3 additions & 3 deletions services/migrations/gitlab.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -641,10 +641,10 @@ func (g *GitlabDownloader) GetReviews(context base.IssueContext) ([]*base.Review
}

var createdAt time.Time
if approvals.UpdatedAt != nil {
createdAt = *approvals.UpdatedAt
} else if approvals.CreatedAt != nil {
if approvals.CreatedAt != nil {
createdAt = *approvals.CreatedAt
} else if approvals.UpdatedAt != nil {
createdAt = *approvals.UpdatedAt
} else {
createdAt = time.Now()
}
Expand Down