Skip to content

fix/define autochecked checkboxes on issue list in firefox #7320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 12, 2019
Merged

fix/define autochecked checkboxes on issue list in firefox #7320

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
529f2aa
fix/define autochecked checkboxes on issue list on firefox
Cherrg Jun 28, 2019
8599e42
remove unnessesary timeouts
Cherrg Jun 28, 2019
dbe347f
add comments in code - this is targeting firefox
Cherrg Jul 12, 2019
0786b82
Merge branch 'master' into issues_checkboxes_behavior
Cherrg Jul 12, 2019
2506ff3
Merge branch 'master' into issues_checkboxes_behavior
zeripath Jul 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion public/js/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2147,7 +2147,21 @@ $(document).ready(function () {
elementId = '';
action = 'clear';
}
updateIssuesMeta(url, action, issueIDs, elementId).then(reload);
updateIssuesMeta(url, action, issueIDs, elementId).then(function() {
// NOTICE: This reset of checkbox state targets Firefox caching behaviour, as the checkboxes stay checked after reload
if (action === "close" || action === "open" ){
//uncheck all checkboxes
$('.issue-checkbox input[type="checkbox"]').each(function(_,e){ e.checked = false; });
}
reload();
});
});

// NOTICE: This event trigger targets Firefox caching behaviour, as the checkboxes stay checked after reload
// trigger ckecked event, if checkboxes are checked on load
$('.issue-checkbox input[type="checkbox"]:checked').first().each(function(_,e) {
e.checked = false;
$(e).click();
});

buttonsClickOnEnter();
Expand Down