Skip to content

A whisper of many aggregation policies (with percentiles) #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Civil merged 10 commits into from
Dec 31, 2019
Merged

A whisper of many aggregation policies (with percentiles) #5

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
67dc1cb
mix: initial supports for a new aggregation policy: mix (with percent…
bom-d-van May 12, 2019
4409fc4
mix: add some docs and fix Whisper.bufferSize
bom-d-van May 19, 2019
23dc23b
mix: add TestFillCompressedByMix and update comments
bom-d-van Nov 9, 2019
93d9efc
mix: multiple bug fixes and refactorings for both mix or non-mix logics
bom-d-van Dec 8, 2019
6941e73
mix: correct percentile caculation
bom-d-van Dec 9, 2019
8a3bdde
mix: update comments and clean up commented out codes, todos
bom-d-van Dec 19, 2019
beabc51
debug: add end_offset in archive header, fix off-by-1 in count output…
bom-d-van Dec 22, 2019
f1a7fb0
mix: FetchByAggregation: ignore spec if aggregation method is not mix
bom-d-van Dec 28, 2019
0246244
mix: a bug fix for dynamic read backfilling and a propagation buffer …
bom-d-van Dec 28, 2019
6c5f01b
mix: rename var with a bit of self-explainatory code changes, and bet…
bom-d-van Dec 31, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
mix: rename var with a bit of self-explainatory code changes, and bet… 
…ter output
  • Loading branch information
@bom-d-van
bom-d-van committed Dec 31, 2019
commit 6c5f01b435e1393d8da3abfd46ede4fe07392a51
2 changes: 1 addition & 1 deletion cmd/read.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ func main() {
}

if db.Extended {
fmt.Println("file is extended.")
fmt.Println("file has been extended.")
}
}

Expand Down
8 changes: 4 additions & 4 deletions compress.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,12 +90,12 @@ func (whisper *Whisper) WriteHeaderCompressed() (err error) {
i += packInt(b, archive.blockCount, i)
i += packFloat32(b, archive.avgCompressedPointSize, i)

var mixSpec int
var mixSpecSize int
if archive.aggregationSpec != nil {
b[i] = byte(archive.aggregationSpec.Method)
i += ByteSize
i += packFloat32(b, archive.aggregationSpec.Percentile, i)
mixSpec = 5
mixSpecSize = ByteSize + FloatSize
}

i += packInt(b, archive.cblock.index, i)
Expand All @@ -114,9 +114,9 @@ func (whisper *Whisper) WriteHeaderCompressed() (err error) {
i += packInt(b, int(archive.stats.discard.oldInterval), i)
i += packInt(b, int(archive.stats.extended), i)

i += FreeCompressedArchiveInfoSize - mixSpec
i += FreeCompressedArchiveInfoSize - mixSpecSize

if FreeCompressedArchiveInfoSize < mixSpec {
if FreeCompressedArchiveInfoSize < mixSpecSize {
panic("out of FreeCompressedArchiveInfoSize") // a panic that should never happens
}
}
Expand Down