feat: add origin validator for web origin URLs#1565
Merged
Conversation
Signed-off-by: Ahmed Kamal <ahmed@ahmedkamal.io>
nodivbyzero
reviewed
Apr 20, 2026
nodivbyzero
reviewed
Apr 20, 2026
nodivbyzero
reviewed
Apr 20, 2026
- Replace permissive RFC1123 hostname regex with one that rejects leading/ trailing hyphens per label, empty labels, and trailing dots - Reorder origin host check to try net.ParseIP before regex (cheaper path for IP literals) and simplify single-case switch to an if - Add tests covering invalid hostname/origin edge cases Signed-off-by: Ahmed Kamal <ahmed@ahmedkamal.io>
Contributor
Author
nodivbyzero
approved these changes
Apr 27, 2026
1 task
zemzale
pushed a commit
that referenced
this pull request
Apr 29, 2026
## Fixes Or Enhances Similar to the recent fix #1565 6bcb7bc RFC 952 is now fixed to reject hostname labels with trailing hyphen **Make sure that you've checked the boxes below before you submit PR:** - [x] Tests exist or have been written that cover this particular change. @go-playground/validator-maintainers Signed-off-by: Ahmed Kamal <ahmed@ahmedkamal.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Or Enhances
Added
origintag for web origin URLs.Make sure that you've checked the boxes below before you submit PR:
@go-playground/validator-maintainers