Expose errors returned by validateFn#1579
Open
puneetdixit200 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Or Enhances
Fixes #1575.
validateFnmethods that return a non-nilerrornow keep that error attached to the generated field validation error. Callers can inspect it witherrors.Isorerrors.Asthrough either the returnedValidationErrorsvalue or the individualFieldError.This keeps the existing
FieldErrorinterface and validation failure shape unchanged while making the underlyingValidate() errorresult accessible.Make sure that you've checked the boxes below before you submit PR:
Verification
GOMODCACHE=/tmp/validator-gomodcache GOCACHE=/tmp/validator-gocache go test ./... -run TestValidateFn -count=1GOMODCACHE=/tmp/validator-gomodcache GOCACHE=/tmp/validator-gocache go test -cover -race ./...PATH=/tmp/validator-bin:$PATH GOMODCACHE=/tmp/validator-gomodcache GOCACHE=/tmp/validator-gocache golangci-lint rungit diff --check@go-playground/validator-maintainers