Skip to content

feat: remote taskfiles (HTTP) #1152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pd93 merged 17 commits into from
Sep 12, 2023
Merged

feat: remote taskfiles (HTTP) #1152

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
c8544f1
feat: remote taskfiles over http
pd93 May 16, 2023
eb24684
feat: allow insecure connections when --insecure flag is provided
pd93 May 16, 2023
1485829
feat: better error handling for fetch errors
pd93 May 16, 2023
47c8a50
fix: ensure cache directory always exists
pd93 Aug 29, 2023
394bfbe
fix: setup logger before everything else
pd93 Aug 29, 2023
6e26c19
feat: put remote taskfiles behind an experiment
pd93 Aug 29, 2023
74fd327
feat: --download and --offline flags for remote taskfiles
pd93 Sep 1, 2023
dc32ac9
feat: node.Read accepts a context
pd93 Sep 2, 2023
6ca7bfc
feat: experiment docs
pd93 Sep 2, 2023
6971bf5
chore: changelog
pd93 Sep 2, 2023
2e7acfe
chore: remove unused optional param from Node interface
pd93 Sep 3, 2023
8a2c112
chore: tidy up and generalise NewNode function
pd93 Sep 3, 2023
a2f2f88
fix: use sha256 in remote checksum
pd93 Sep 4, 2023
69871dd
feat: --download by itself will not run a task
pd93 Sep 4, 2023
1c93c01
feat: custom error if remote taskfiles experiment is not enabled
pd93 Sep 4, 2023
732fe79
refactor: BaseNode functional options and simplified FileNode
pd93 Sep 5, 2023
756084c
fix: use hex encoding for checksum instead of b64
pd93 Sep 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feat: --download by itself will not run a task
  • Loading branch information
@pd93
pd93 committed Sep 4, 2023
commit 69871ddf7f67408674decb52cae6b9c8664d2f79
12 changes: 2 additions & 10 deletions args/args.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import (

// ParseV3 parses command line argument: tasks and global variables
func ParseV3(args ...string) ([]taskfile.Call, *taskfile.Vars) {
var calls []taskfile.Call
calls := []taskfile.Call{}
globals := &taskfile.Vars{}

for _, arg := range args {
Expand All @@ -21,16 +21,12 @@ func ParseV3(args ...string) ([]taskfile.Call, *taskfile.Vars) {
globals.Set(name, taskfile.Var{Static: value})
}

if len(calls) == 0 {
calls = append(calls, taskfile.Call{Task: "default", Direct: true})
}

return calls, globals
}

// ParseV2 parses command line argument: tasks and vars of each task
func ParseV2(args ...string) ([]taskfile.Call, *taskfile.Vars) {
var calls []taskfile.Call
calls := []taskfile.Call{}
globals := &taskfile.Vars{}

for _, arg := range args {
Expand All @@ -51,10 +47,6 @@ func ParseV2(args ...string) ([]taskfile.Call, *taskfile.Vars) {
}
}

if len(calls) == 0 {
calls = append(calls, taskfile.Call{Task: "default", Direct: true})
}

return calls, globals
}

Expand Down
36 changes: 12 additions & 24 deletions args/args_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,22 +73,16 @@ func TestArgsV3(t *testing.T) {
},
},
{
Args: nil,
ExpectedCalls: []taskfile.Call{
{Task: "default", Direct: true},
},
Args: nil,
ExpectedCalls: []taskfile.Call{},
},
{
Args: []string{},
ExpectedCalls: []taskfile.Call{
{Task: "default", Direct: true},
},
Args: []string{},
ExpectedCalls: []taskfile.Call{},
},
{
Args: []string{"FOO=bar", "BAR=baz"},
ExpectedCalls: []taskfile.Call{
{Task: "default", Direct: true},
},
Args: []string{"FOO=bar", "BAR=baz"},
ExpectedCalls: []taskfile.Call{},
ExpectedGlobals: &taskfile.Vars{
OrderedMap: orderedmap.FromMapWithOrder(
map[string]taskfile.Var{
Expand Down Expand Up @@ -191,22 +185,16 @@ func TestArgsV2(t *testing.T) {
},
},
{
Args: nil,
ExpectedCalls: []taskfile.Call{
{Task: "default", Direct: true},
},
Args: nil,
ExpectedCalls: []taskfile.Call{},
},
{
Args: []string{},
ExpectedCalls: []taskfile.Call{
{Task: "default", Direct: true},
},
Args: []string{},
ExpectedCalls: []taskfile.Call{},
},
{
Args: []string{"FOO=bar", "BAR=baz"},
ExpectedCalls: []taskfile.Call{
{Task: "default", Direct: true},
},
Args: []string{"FOO=bar", "BAR=baz"},
ExpectedCalls: []taskfile.Call{},
ExpectedGlobals: &taskfile.Vars{
OrderedMap: orderedmap.FromMapWithOrder(
map[string]taskfile.Var{
Expand Down
7 changes: 7 additions & 0 deletions cmd/task/task.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,6 +295,13 @@ func run() error {
calls, globals = args.ParseV2(tasksAndVars...)
}

// If there are no calls, run the default task instead
// Unless the download flag is specified, in which case we want to download
// the Taskfile and do nothing else
if len(calls) == 0 && !flags.download {
calls = append(calls, taskfile.Call{Task: "default", Direct: true})
}

globals.Set("CLI_ARGS", taskfile.Var{Static: cliArgs})
e.Taskfile.Vars.Merge(globals)

Expand Down