Skip to content

fix: ignore all errors when reading dotenv for experiments #1245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andreynering merged 1 commit into from
Jun 30, 2023
Merged

fix: ignore all errors when reading dotenv for experiments #1245

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 3 additions & 13 deletions internal/experiments/experiments.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
package experiments

import (
"errors"
"fmt"
"os"
"strings"
Expand All @@ -17,9 +16,7 @@ const envPrefix = "TASK_X_"
var GentleForce bool

func init() {
if err := readDotEnv(); err != nil {
panic(err)
}
readDotEnv()
GentleForce = parseEnv("GENTLE_FORCE")
}

Expand All @@ -28,21 +25,14 @@ func parseEnv(xName string) bool {
return os.Getenv(envName) == "1"
}

func readDotEnv() error {
env, err := godotenv.Read()
if errors.Is(err, os.ErrNotExist) {
return nil
}
if err != nil {
return err
}
func readDotEnv() {
env, _ := godotenv.Read()
// If the env var is an experiment, set it.
for key, value := range env {
if strings.HasPrefix(key, envPrefix) {
os.Setenv(key, value)
}
}
return nil
}

func List(l *logger.Logger) error {
Expand Down