Skip to content

Conversation

@wass3r
Copy link
Collaborator

@wass3r wass3r commented Nov 17, 2025

closes go-vela/community#1014

AI says:
Only persist user-specified color theme in config and skip saving default terminal256 format. Auto-detect terminal background to pick light/dark themes by default, respect NO_COLOR, CLICOLOR_FORCE, and CLICOLOR, and allow overriding via --color flags. Add vela view themes command to list available chroma themes and include tests for color behavior.

Only persist user-specified color theme in config and skip saving
default terminal256 format. Auto-detect terminal background to pick
light/dark themes, respect NO_COLOR, CLICOLOR_FORCE, and CLICOLOR, and
allow overriding via --color flags. Add 'vela view themes' command to
list available chroma themes and include tests for color behavior.
@wass3r wass3r requested a review from a team as a code owner November 17, 2025 15:16
@codecov
Copy link

codecov bot commented Nov 17, 2025

Codecov Report

❌ Patch coverage is 91.54930% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.46%. Comparing base (70c52a9) to head (9f7991b).

Files with missing lines Patch % Lines
internal/output/color.go 91.89% 3 Missing ⚠️
command/themes/view.go 91.66% 1 Missing and 1 partial ⚠️
cmd/vela-cli/main.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #624      +/-   ##
==========================================
+ Coverage   70.84%   71.46%   +0.61%     
==========================================
  Files         173      174       +1     
  Lines        4662     4717      +55     
==========================================
+ Hits         3303     3371      +68     
+ Misses       1055     1041      -14     
- Partials      304      305       +1     
Files with missing lines Coverage Δ
action/config/generate.go 84.00% <100.00%> (+0.66%) ⬆️
cmd/vela-cli/main.go 0.00% <0.00%> (ø)
command/themes/view.go 91.66% <91.66%> (ø)
internal/output/color.go 90.19% <91.89%> (+81.10%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

default color output not suitable on terminals with light background

4 participants