Skip to content
This repository was archived by the owner on Jan 27, 2025. It is now read-only.

chore(installation): worker registration docs #354

Merged
ecrupper merged 7 commits into from
Apr 25, 2023
Merged

chore(installation): worker registration docs #354

ecrupper merged 7 commits into from
Apr 25, 2023

Conversation

@ecrupper
Copy link
Contributor

@ecrupper ecrupper commented Apr 7, 2023

cognifloyd
cognifloyd previously approved these changes Apr 9, 2023
View reviewed changes
@ecrupper ecrupper marked this pull request as ready for review April 25, 2023 16:04
@ecrupper ecrupper requested a review from a team as a code owner April 25, 2023 16:04
wass3rw3rk
wass3rw3rk previously approved these changes Apr 25, 2023
View reviewed changes
Copy link
Member

@wass3rw3rk wass3rw3rk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not crucial, but i noticed a lot of manual line breaks. we really don't need that, so the text can flow naturally depending on resolution, otherwise you get funky breaks when you resize browser.

@ecrupper ecrupper removed the next label Apr 25, 2023
@ecrupper ecrupper merged commit d89ba33 into main Apr 25, 2023
@ecrupper ecrupper deleted the worker-registration-docs branch April 25, 2023 21:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

4 more reviewers

@timhuynh94 timhuynh94 timhuynh94 approved these changes

@plyr4 plyr4 plyr4 approved these changes

@cognifloyd cognifloyd cognifloyd left review comments

@wass3rw3rk wass3rw3rk wass3rw3rk left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

0.19.x

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ecrupper @cognifloyd @timhuynh94 @plyr4 @wass3rw3rk