This repository was archived by the owner on Oct 28, 2021. It is now read-only.
fix(kubernetes): ensure logs for fast exiting steps are retrieved #151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #151 +/- ##
==========================================
- Coverage 81.05% 80.68% -0.37%
==========================================
Files 19 19
Lines 1330 1336 +6
==========================================
Hits 1078 1078
- Misses 217 223 +6
Partials 35 35
|
wass3r
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps can exit quickly, and might be gone before log tailing has started, so we need to request logs for previously exited containers as well.
Pods get deleted after job completion, and names for pod+container don't get reused. So, previous should only retrieve logs for the current build step.