feat: validate+register tests

vela/admin.go

@@ -5,7 +5,9 @@
 package vela
 
 import (
+	"errors"
 	"fmt"
+	"strings"
 
 	"github.com/go-vela/types/library"
 )
@@ -204,10 +206,15 @@ func (svc *AdminUserService) Update(u *library.User) (*library.User, *Response,
 	return v, resp, err
 }
 
-// RegistrationToken generates a worker registration token with the provided details.
-func (svc *AdminUserService) RegistrationToken(w *library.Worker) (*library.Token, *Response, error) {
+// RegisterToken generates a worker registration token with the provided details.
+func (svc *AdminWorkerService) RegisterToken(hostname string) (*library.Token, *Response, error) {
+	// validate input
+	if strings.EqualFold(hostname, "") {
+		return nil, nil, errors.New("bad request, no hostname provided")
+	}
+
 	// set the API endpoint path we send the request to
-	url := fmt.Sprintf("/api/v1/workers/%s/register-token", w.GetHostname())
+	url := fmt.Sprintf("/api/v1/workers/%s/register-token", hostname)
 
 	// library Token type we want to return
 	t := new(library.Token)

vela/admin_test.go

@@ -326,3 +326,55 @@ func TestAdmin_Build_Queue_200(t *testing.T) {
 		t.Errorf("GetQueue() mismatch (-want +got):\n%s", diff)
 	}
 }
+
+func TestAdmin_Worker_RegistrationToken_200(t *testing.T) {
+	// setup context
+	gin.SetMode(gin.TestMode)
+
+	s := httptest.NewServer(server.FakeHandler())
+	c, _ := NewClient(s.URL, "", nil)
+
+	// needs mocks from server feature
+	// data := []byte(server.RegisterTokenResp)
+	data := []byte{}
+
+	var want *library.Token
+
+	err := json.Unmarshal(data, &want)
+	if err != nil {
+		t.Error(err)
+	}
+
+	hostname := "foo"
+
+	// run test
+	got, resp, err := c.Admin.Worker.RegisterToken(hostname)
+	if err != nil {
+		t.Errorf("RegisterToken returned err: %v", err)
+	}
+
+	if resp.StatusCode != http.StatusOK {
+		t.Errorf("RegisterToken returned %v, want %v", resp.StatusCode, http.StatusOK)
+	}
+
+	if diff := cmp.Diff(want, got); diff != "" {
+		t.Errorf("RegisterToken() mismatch (-want +got):\n%s", diff)
+	}
+}
+
+func TestAdmin_Worker_RegistrationToken_NoHostname(t *testing.T) {
+	// setup context
+	gin.SetMode(gin.TestMode)
+
+	s := httptest.NewServer(server.FakeHandler())
+	c, _ := NewClient(s.URL, "", nil)
+
+	// bad hostname
+	hostname := ""
+
+	// run test
+	_, _, err := c.Admin.Worker.RegisterToken(hostname)
+	if err == nil {
+		t.Error("RegisterToken should have returned err")
+	}
+}

vela/authentication.go

@@ -211,5 +211,6 @@ func (svc *AuthenticationService) ValidateToken() (*Response, error) {
 
 	// attempt to validate a server token
 	resp, err := svc.client.Call("GET", u, nil, nil)
+
 	return resp, err
 }

vela/authentication_test.go

@@ -204,3 +204,49 @@ func TestVela_Authentication_ExchangeTokens_BadInput(t *testing.T) {
 		t.Errorf("ExchangeTokens should not set Refresh Token")
 	}
 }
+
+func TestVela_Authentication_ValidateToken_200(t *testing.T) {
+	// setup context
+	gin.SetMode(gin.TestMode)
+
+	s := httptest.NewServer(server.FakeHandler())
+	c, _ := NewClient(s.URL, "", nil)
+
+	c.Authentication.SetTokenAuth("foobar")
+
+	// run test
+	resp, err := c.Authentication.ValidateToken()
+
+	if err != nil {
+		t.Errorf("ValidateToken returned error %v", err)
+	}
+
+	if resp == nil {
+		t.Errorf("ValidateToken response should not be nil")
+	}
+
+	if resp.StatusCode != http.StatusOK {
+		t.Errorf("ValidateToken returned %v, want %v", resp.StatusCode, http.StatusOK)
+	}
+}
+
+func TestVela_Authentication_ValidateToken_NoToken(t *testing.T) {
+	// setup context
+	gin.SetMode(gin.TestMode)
+
+	s := httptest.NewServer(server.FakeHandler())
+	c, _ := NewClient(s.URL, "", nil)
+
+	c.Authentication.SetTokenAuth("")
+
+	// run test
+	resp, err := c.Authentication.ValidateToken()
+
+	if err == nil {
+		t.Error("ValidateToken should have returned error")
+	}
+
+	if resp != nil {
+		t.Errorf("ValidateToken response should be nil")
+	}
+}