Skip to content

chore(tracing): rename cli key #1187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
plyr4 merged 2 commits into from
Sep 18, 2024
Merged

chore(tracing): rename cli key #1187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c85ab6
chore(tracing): rename cli key
plyr4 Sep 17, 2024
90d0514
chore(tracing): rename cli key
plyr4 Sep 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions tracing/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,17 +68,17 @@ func FromCLIContext(c *cli.Context) (*Client, error) {
},
}

// read per-endpoint configurations from file
endpointsConfigPath := c.String("tracing.sampler.endpoints")
if len(endpointsConfigPath) > 0 {
f, err := os.ReadFile(endpointsConfigPath)
// read per-task configurations from file
tasksConfigPath := c.String("tracing.sampler.tasks")
if len(tasksConfigPath) > 0 {
f, err := os.ReadFile(tasksConfigPath)
if err != nil {
return nil, errors.Wrap(err, fmt.Sprintf("unable to read tracing endpoints config file from path %s", endpointsConfigPath))
return nil, errors.Wrap(err, fmt.Sprintf("unable to read tracing tasks config file from path %s", tasksConfigPath))
}

err = json.Unmarshal(f, &cfg.Sampler.Tasks)
if err != nil {
return nil, errors.Wrap(err, fmt.Sprintf("unable to parse tracing endpoints config file from path %s", endpointsConfigPath))
return nil, errors.Wrap(err, fmt.Sprintf("unable to parse tracing tasks config file from path %s", tasksConfigPath))
}
}

Expand Down
2 changes: 1 addition & 1 deletion tracing/flags.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ var Flags = []cli.Flag{

&cli.StringFlag{
EnvVars: []string{"VELA_OTEL_TRACING_SAMPLER_TASKS_CONFIG_FILEPATH"},
Name: "tracing.sampler.endpoints",
Name: "tracing.sampler.tasks",
Usage: "set an (optional) filepath to the otel tracing head-sampler configurations json to alter how certain tasks (endpoints, queries, etc) are sampled. when no path is provided all tasks are recorded using default parameters. see: https://opentelemetry.io/docs/concepts/sampling/",
},
}