fix(yaml): bubble up rules struct unmarshal errors #1256
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like these two unchecked
unmarshalcalls were part of the initial go-vela/types commit, so I am not sure if there is some extra backstory here that I'm missing. However, it would be nice to bubble up errors here, since suppressing them just returns an empty rules block which gets converted to no rules.converts to -->
Before:
After:
FWIW, the unmarshaler is not strict on fields, so this won't break pipelines that are using unknown fields (threw in a test just to confirm).