Skip to content

fix(revert): reverting a couple of 0.26.2 fixes #1267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wass3rw3rk merged 2 commits into from
Mar 10, 2025

Revert "fix(yaml): bubble up rules struct unmarshal errors (#1256)"

5a89e9f
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

fix(revert): reverting a couple of 0.26.2 fixes #1267

Revert "fix(yaml): bubble up rules struct unmarshal errors (#1256)"
5a89e9f
Select commit
Loading
Failed to load commit list.
GitHub Actions / golangci failed Mar 10, 2025 in 0s

reviewdog [golangci] report

reported by reviewdog 🐶

Findings (16)

compiler/native/expand.go|403 col 33| string golang has 3 occurrences, make it a constant (goconst)
compiler/native/compile_test.go|2449 col 13| SA1019: github.String is deprecated: use Ptr instead. (staticcheck)
compiler/native/compile_test.go|2450 col 13| SA1019: github.String is deprecated: use Ptr instead. (staticcheck)
scm/github/app_permissions.go|62 col 20| SA1019: github.String is deprecated: use Ptr instead. (staticcheck)
scm/github/deployment.go|180 col 21| SA1019: github.Bool is deprecated: use Ptr instead. (staticcheck)
scm/github/repo.go|209 col 11| SA1019: github.Bool is deprecated: use Ptr instead. (staticcheck)
scm/github/repo.go|283 col 11| SA1019: github.Bool is deprecated: use Ptr instead. (staticcheck)
scm/github/github_client_test.go|76 col 9| SA1019: github.Int64 is deprecated: use Ptr instead. (staticcheck)
scm/github/github_client_test.go|90 col 9| SA1019: github.Int64 is deprecated: use Ptr instead. (staticcheck)
scm/github/github_client_test.go|104 col 9| SA1019: github.Int64 is deprecated: use Ptr instead. (staticcheck)
queue/redis/redis.go|46 col 1| directive //nolint:revive // ignore returning unexported client is unused for linter "revive" (nolintlint)
queue/redis/redis.go|182 col 1| directive //nolint:revive // ignore returning unexported client is unused for linter "revive" (nolintlint)
compiler/registry/github/github.go|33 col 1| directive //nolint:revive // ignore returning unexported client is unused for linter "revive" (nolintlint)
database/dashboard/dashboard.go|56 col 1| directive //nolint:revive // ignore returning unexported engine is unused for linter "revive" (nolintlint)
database/repo/repo.go|45 col 1| directive //nolint:revive // ignore returning unexported engine is unused for linter "revive" (nolintlint)
database/build/build.go|45 col 1| directive //nolint:revive // ignore returning unexported engine is unused for linter "revive" (nolintlint)

Filtered Findings (0)

Annotations

Check failure on line 403 in compiler/native/expand.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] compiler/native/expand.go#L403 

string `golang` has 3 occurrences, make it a constant (goconst)
Raw output 
compiler/native/expand.go:403:33: string `golang` has 3 occurrences, make it a constant (goconst)
	case constants.PipelineTypeGo, "golang", "":
	                               ^

Check failure on line 2449 in compiler/native/compile_test.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] compiler/native/compile_test.go#L2449 

SA1019: github.String is deprecated: use Ptr instead. (staticcheck)
Raw output 
compiler/native/compile_test.go:2449:13: SA1019: github.String is deprecated: use Ptr instead. (staticcheck)
		Encoding: github.String(""),
		          ^

Check failure on line 2450 in compiler/native/compile_test.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] compiler/native/compile_test.go#L2450 

SA1019: github.String is deprecated: use Ptr instead. (staticcheck)
Raw output 
compiler/native/compile_test.go:2450:13: SA1019: github.String is deprecated: use Ptr instead. (staticcheck)
		Content:  github.String(string(body)),
		          ^

Check failure on line 62 in scm/github/app_permissions.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] scm/github/app_permissions.go#L62 

SA1019: github.String is deprecated: use Ptr instead. (staticcheck)
Raw output 
scm/github/app_permissions.go:62:20: SA1019: github.String is deprecated: use Ptr instead. (staticcheck)
		perms.Contents = github.String(perm)
		                 ^

Check failure on line 180 in scm/github/deployment.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] scm/github/deployment.go#L180 

SA1019: github.Bool is deprecated: use Ptr instead. (staticcheck)
Raw output 
scm/github/deployment.go:180:21: SA1019: github.Bool is deprecated: use Ptr instead. (staticcheck)
		AutoMerge:        github.Bool(false),
		                  ^

Check failure on line 209 in scm/github/repo.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] scm/github/repo.go#L209 

SA1019: github.Bool is deprecated: use Ptr instead. (staticcheck)
Raw output 
scm/github/repo.go:209:11: SA1019: github.Bool is deprecated: use Ptr instead. (staticcheck)
		Active: github.Bool(true),
		        ^

Check failure on line 283 in scm/github/repo.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] scm/github/repo.go#L283 

SA1019: github.Bool is deprecated: use Ptr instead. (staticcheck)
Raw output 
scm/github/repo.go:283:11: SA1019: github.Bool is deprecated: use Ptr instead. (staticcheck)
		Active: github.Bool(true),
		        ^

Check failure on line 76 in scm/github/github_client_test.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] scm/github/github_client_test.go#L76 

SA1019: github.Int64 is deprecated: use Ptr instead. (staticcheck)
Raw output 
scm/github/github_client_test.go:76:9: SA1019: github.Int64 is deprecated: use Ptr instead. (staticcheck)
				ID: github.Int64(1),
				    ^

Check failure on line 90 in scm/github/github_client_test.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] scm/github/github_client_test.go#L90 

SA1019: github.Int64 is deprecated: use Ptr instead. (staticcheck)
Raw output 
scm/github/github_client_test.go:90:9: SA1019: github.Int64 is deprecated: use Ptr instead. (staticcheck)
				ID: github.Int64(2),
				    ^

Check failure on line 104 in scm/github/github_client_test.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] scm/github/github_client_test.go#L104 

SA1019: github.Int64 is deprecated: use Ptr instead. (staticcheck)
Raw output 
scm/github/github_client_test.go:104:9: SA1019: github.Int64 is deprecated: use Ptr instead. (staticcheck)
				ID: github.Int64(1),
				    ^

Check failure on line 46 in queue/redis/redis.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] queue/redis/redis.go#L46 

directive `//nolint:revive // ignore returning unexported client` is unused for linter "revive" (nolintlint)
Raw output 
queue/redis/redis.go:46:1: directive `//nolint:revive // ignore returning unexported client` is unused for linter "revive" (nolintlint)
//nolint:revive // ignore returning unexported client
^

Check failure on line 182 in queue/redis/redis.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] queue/redis/redis.go#L182 

directive `//nolint:revive // ignore returning unexported client` is unused for linter "revive" (nolintlint)
Raw output 
queue/redis/redis.go:182:1: directive `//nolint:revive // ignore returning unexported client` is unused for linter "revive" (nolintlint)
//nolint:revive // ignore returning unexported client
^

Check failure on line 33 in compiler/registry/github/github.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] compiler/registry/github/github.go#L33 

directive `//nolint:revive // ignore returning unexported client` is unused for linter "revive" (nolintlint)
Raw output 
compiler/registry/github/github.go:33:1: directive `//nolint:revive // ignore returning unexported client` is unused for linter "revive" (nolintlint)
//nolint:revive // ignore returning unexported client
^

Check failure on line 56 in database/dashboard/dashboard.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] database/dashboard/dashboard.go#L56 

directive `//nolint:revive // ignore returning unexported engine` is unused for linter "revive" (nolintlint)
Raw output 
database/dashboard/dashboard.go:56:1: directive `//nolint:revive // ignore returning unexported engine` is unused for linter "revive" (nolintlint)
//nolint:revive // ignore returning unexported engine
^

Check failure on line 45 in database/repo/repo.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] database/repo/repo.go#L45 

directive `//nolint:revive // ignore returning unexported engine` is unused for linter "revive" (nolintlint)
Raw output 
database/repo/repo.go:45:1: directive `//nolint:revive // ignore returning unexported engine` is unused for linter "revive" (nolintlint)
//nolint:revive // ignore returning unexported engine
^

Check failure on line 45 in database/build/build.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] database/build/build.go#L45 

directive `//nolint:revive // ignore returning unexported engine` is unused for linter "revive" (nolintlint)
Raw output 
database/build/build.go:45:1: directive `//nolint:revive // ignore returning unexported engine` is unused for linter "revive" (nolintlint)
//nolint:revive // ignore returning unexported engine
^
View more details on GitHub Actions