Skip to content

Conversation

@ecrupper
Copy link
Contributor

@ecrupper ecrupper commented Nov 4, 2025

Maps are rendering with raw YAML nodes after migrating to the YAML-owned yaml package. Will have to investigate further and address issues in v0.28, but for now, this patch will just go back to the previous YAML lib.

backports #1363

@ecrupper ecrupper requested a review from a team as a code owner November 4, 2025 18:56
@codecov
Copy link

codecov bot commented Nov 4, 2025

Codecov Report

❌ Patch coverage is 12.50000% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.51%. Comparing base (d62d7ec) to head (c86e48e).
⚠️ Report is 1 commits behind head on v0.27.3-patch.

Files with missing lines Patch % Lines
mock/server/pipeline.go 0.00% 10 Missing ⚠️
api/pipeline/output.go 33.33% 3 Missing and 1 partial ⚠️

❌ Your project status has failed because the head coverage (58.51%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           v0.27.3-patch    #1362      +/-   ##
=================================================
+ Coverage          56.81%   58.51%   +1.70%     
=================================================
  Files                647      647              
  Lines              36738    25391   -11347     
=================================================
- Hits               20873    14858    -6015     
+ Misses             15210     9876    -5334     
- Partials             655      657       +2     
Files with missing lines Coverage Δ
api/pipeline/output.go 57.14% <33.33%> (+57.14%) ⬆️
mock/server/pipeline.go 0.00% <0.00%> (ø)

... and 634 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

KellyMerrick
KellyMerrick previously approved these changes Nov 4, 2025
@wass3r
Copy link
Collaborator

wass3r commented Nov 4, 2025

do you have a test case or sample YAML pipeline, might be nice to have in a new issue w/ reproducible steps? looking at yaml/go-yaml@v3.0.1...v3.0.4, only a couple of commits jump out as possible culprits. i'd prefer to go to v3.0.1 of the current, supported package, if we really have to. it has the same commit sha as the old lib and should be identical to what we are changing this to:

go-yaml/yaml@f6f7691
yaml/go-yaml@f6f7691

@ecrupper
Copy link
Contributor Author

ecrupper commented Nov 6, 2025

do you have a test case or sample YAML pipeline, might be nice to have in a new issue w/ reproducible steps?

version: "1"

stages:
  alpha:
    steps:
      - name: view alpha message
        image: alpine:latest
        commands:
          - echo alpha

  beta:
    steps:
      - name: view beta message
        image: alpine:latest
        commands:
          - echo beta   

This pipeline will produce the following on expand:

version: "1"
metadata:
    environment:
        - steps
        - services
        - secrets
stages:
    kind: 4
    style: 0
    tag: ""
    value: ""
    anchor: ""
    alias: null
    content:
        - kind: 8
          style: 0
          tag: ""
          value: alpha
          anchor: ""
          alias: null
          content: []
          headcomment: ""
          linecomment: ""
          footcomment: ""
          line: 0
          column: 0
        - kind: 4
          style: 0
          tag: '!!map'
          value: ""
          anchor: ""
          alias: null
          content:

# and so on

Copy link
Collaborator

@wass3r wass3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

waiting for changes to repurpose this PR to apply changes from #1363 to v0.27.3

@wass3rw3rk wass3rw3rk changed the title fix(patch-v0.27.3): revert YAML library change fix(patch-v0.27.3): backport yaml expansion fix Nov 13, 2025
@ecrupper ecrupper merged commit b4d734a into v0.27.3-patch Nov 13, 2025
10 of 13 checks passed
@ecrupper ecrupper deleted the patch/revert-yaml-pkg branch November 13, 2025 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants