-
Notifications
You must be signed in to change notification settings - Fork 30
fix(patch-v0.27.3): backport yaml expansion fix #1362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
❌ Your project status has failed because the head coverage (58.51%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## v0.27.3-patch #1362 +/- ##
=================================================
+ Coverage 56.81% 58.51% +1.70%
=================================================
Files 647 647
Lines 36738 25391 -11347
=================================================
- Hits 20873 14858 -6015
+ Misses 15210 9876 -5334
- Partials 655 657 +2
🚀 New features to boost your workflow:
|
|
do you have a test case or sample YAML pipeline, might be nice to have in a new issue w/ reproducible steps? looking at yaml/go-yaml@v3.0.1...v3.0.4, only a couple of commits jump out as possible culprits. i'd prefer to go to |
version: "1"
stages:
alpha:
steps:
- name: view alpha message
image: alpine:latest
commands:
- echo alpha
beta:
steps:
- name: view beta message
image: alpine:latest
commands:
- echo beta This pipeline will produce the following on version: "1"
metadata:
environment:
- steps
- services
- secrets
stages:
kind: 4
style: 0
tag: ""
value: ""
anchor: ""
alias: null
content:
- kind: 8
style: 0
tag: ""
value: alpha
anchor: ""
alias: null
content: []
headcomment: ""
linecomment: ""
footcomment: ""
line: 0
column: 0
- kind: 4
style: 0
tag: '!!map'
value: ""
anchor: ""
alias: null
content:
# and so on |
wass3r
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
waiting for changes to repurpose this PR to apply changes from #1363 to v0.27.3
Maps are rendering with raw YAML nodes after migrating to the YAML-owned yaml package.
Will have to investigate further and address issues in v0.28, but for now, this patch will just go back to the previous YAML lib.backports #1363