fix(postgres): add workaround for gorm record not found #409
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leftover work for go-vela/community#248
Related to go-gorm/gorm#4416
This is a workaround to a problem found in an upstream library.
This updates the
go-vela/server/database/postgresclient to specifically check for the rows returned from queries:server/database/postgres/build.go
Lines 35 to 38 in 95e6969
You'll note that we are explicitly checking the
RowsAffectedfield is equal to0from the result returned by GORM.This is required due to what initially appears to be a bug in GORM (See above go-gorm/gorm issue for more details).
GORM no longer returns
record not foundwhen a query is ran against the database and no rows are returned.