fix(api): listing empty deployments for repo #496
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-fevold
approved these changes
Oct 15, 2021
meinenec
approved these changes
Oct 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based off of #471
Related to go-vela/community#364
This issue was discovered in the latest RC:
https://github.com/go-vela/server/releases/tag/v0.10.0-rc2
When navigating to a repo in the Vela UI with no deployments, you'll see a TOAST error message:
Unfortunately, this error message will be displayed even when you are not on the
Deploymentstab in the UI.If you navigate to the
Deploymentstab in the UI, you'll see an "infinite" spinning wheel with the TOAST error message:The reason for this issue is due to us creating an empty slice of deployments as a variable
dWithBs:server/api/deployment.go
Line 214 in 64f8df2
However, we never actually initialize that variable which causes a
nullvalue to be returned by the server to the UI:server/api/deployment.go
Line 241 in 64f8df2