-
Notifications
You must be signed in to change notification settings - Fork 30
enhance: inform user what to do when the version property is missing #577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
While setting up a new pipeline, I couldn't quite figure out what I was missing. Turns out, I'd missed something quite important when copypasting from an existing configuration, and neither the server nor the vela CLI could tell me what was wrong! This disambiguates that error message by providing a remedy.
|
N.b. I did this in GH editor, so I'm bracing for some style errors at minimum ;-) |
Codecov Report
@@ Coverage Diff @@
## master #577 +/- ##
=======================================
Coverage 54.44% 54.44%
=======================================
Files 181 181
Lines 15136 15136
=======================================
Hits 8241 8241
Misses 6578 6578
Partials 317 317
|
KellyMerrick
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
kneal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🐬
While setting up a new pipeline, I couldn't quite figure out what I was missing. Turns out, I'd missed something quite important when copypasting from an existing configuration, and neither the server nor the vela CLI could tell me what was wrong! This disambiguates that error message by providing a remedy.