Skip to content

Conversation

@colindean
Copy link
Contributor

While setting up a new pipeline, I couldn't quite figure out what I was missing. Turns out, I'd missed something quite important when copypasting from an existing configuration, and neither the server nor the vela CLI could tell me what was wrong! This disambiguates that error message by providing a remedy.

While setting up a new pipeline, I couldn't quite figure out what I was missing. Turns out, I'd missed something quite important when copypasting from an existing configuration, and neither the server nor the vela CLI could tell me what was wrong! This disambiguates that error message by providing a remedy.
@colindean colindean requested a review from a team as a code owner January 26, 2022 19:51
@colindean
Copy link
Contributor Author

N.b. I did this in GH editor, so I'm bracing for some style errors at minimum ;-)

@codecov
Copy link

codecov bot commented Jan 26, 2022

Codecov Report

Merging #577 (95a64e8) into master (ea8fadd) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #577   +/-   ##
=======================================
  Coverage   54.44%   54.44%           
=======================================
  Files         181      181           
  Lines       15136    15136           
=======================================
  Hits         8241     8241           
  Misses       6578     6578           
  Partials      317      317           
Impacted Files Coverage Δ
compiler/native/validate.go 100.00% <100.00%> (ø)

Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@kneal kneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐬

@wass3r wass3r changed the title Inform user what to do when the version property is missing enhance: inform user what to do when the version property is missing Feb 16, 2022
@wass3r wass3r merged commit 3f5f628 into go-vela:master Feb 16, 2022
@colindean colindean deleted the patch-1 branch February 19, 2022 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants