fix(secrets): actually set updated_at and updated_by fields #578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #578 +/- ##
==========================================
+ Coverage 54.43% 54.44% +0.01%
==========================================
Files 181 181
Lines 15131 15136 +5
==========================================
+ Hits 8236 8241 +5
Misses 6578 6578
Partials 317 317
|
wass3r
approved these changes
Jan 27, 2022
jbrockopp
approved these changes
Jan 27, 2022
Contributor
There was a problem hiding this comment.
LGTM
FWIW:
In the future, we should consider removing this code in the secret/native/update.go file 😅
It feels like we're already handling this logic in the API handler:
https://github.com/go-vela/server/blob/master/api/secret.go#L546-L547
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually setting the metadata fields when a secret is updated. I also made the existing test actually test for an update so this hopefully won't happen in the future.