fix(secrets): reject whitespace value secrets #588
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #588 +/- ##
==========================================
- Coverage 54.44% 54.38% -0.06%
==========================================
Files 181 181
Lines 15136 15152 +16
==========================================
Hits 8241 8241
- Misses 6578 6594 +16
Partials 317 317
|
dtanner
previously approved these changes
Feb 17, 2022
jbrockopp
requested changes
Feb 17, 2022
Contributor
jbrockopp
left a comment
jbrockopp
left a comment
There was a problem hiding this comment.
The code LGTM but wondering if we should rephrase the error message.
…rver into fix/reject-whitespace-secrets
wass3r
approved these changes
Feb 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The UI already prevents this by trimming, but you can still create secrets that are solely whitespace via the API endpoint.