Skip to content

fix(api/secrets): reject secrets with only whitespace characters #590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ecrupper merged 1 commit into from
Feb 21, 2022
Merged

fix(api/secrets): reject secrets with only whitespace characters #590

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions api/secret.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,8 @@ import (

// CreateSecret represents the API handler to
// create a secret in the configured backend.
//
// nolint: funlen // ignore funlen linter
func CreateSecret(c *gin.Context) {
// capture middleware values
u := user.Retrieve(c)
Expand Down Expand Up @@ -129,6 +131,16 @@ func CreateSecret(c *gin.Context) {
return
}

// reject secrets with solely whitespace characters as its value
trimmed := strings.TrimSpace(input.GetValue())
if len(trimmed) == 0 {
retErr := fmt.Errorf("secret value must contain non-whitespace characters")

util.HandleError(c, http.StatusBadRequest, retErr)

return
}

// update fields in secret object
input.SetOrg(o)
input.SetRepo(n)
Expand Down Expand Up @@ -544,6 +556,8 @@ func GetSecret(c *gin.Context) {
// "$ref": "#/definitions/Error"

// UpdateSecret updates a secret for the provided secrets service.
//
// nolint: funlen // ignore funlen linter
func UpdateSecret(c *gin.Context) {
// capture middleware values
u := user.Retrieve(c)
Expand Down Expand Up @@ -595,6 +609,16 @@ func UpdateSecret(c *gin.Context) {
return
}

// reject secrets with solely whitespace characters as its value
trimmed := strings.TrimSpace(input.GetValue())
if len(trimmed) == 0 {
retErr := fmt.Errorf("secret value must contain non-whitespace characters")

util.HandleError(c, http.StatusBadRequest, retErr)

return
}

// update secret fields if provided
input.SetName(s)
input.SetOrg(o)
Expand Down