Skip to content

Conversation

@JordanSussman
Copy link
Collaborator

@JordanSussman JordanSussman commented Feb 25, 2022

Add support for utilizing stages within templates.

xref: go-vela/community#233

@codecov
Copy link

codecov bot commented Feb 28, 2022

Codecov Report

Merging #597 (770c636) into master (dc54466) will increase coverage by 0.30%.
The diff coverage is 60.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #597      +/-   ##
==========================================
+ Coverage   54.34%   54.65%   +0.30%     
==========================================
  Files         181      181              
  Lines       15180    15321     +141     
==========================================
+ Hits         8250     8373     +123     
- Misses       6610     6616       +6     
- Partials      320      332      +12     
Impacted Files Coverage Δ
api/pipeline.go 0.00% <0.00%> (ø)
compiler/template/starlark/render.go 46.10% <41.37%> (-0.80%) ⬇️
compiler/native/expand.go 73.75% <62.76%> (+3.08%) ⬆️
compiler/native/compile.go 65.98% <67.63%> (+5.79%) ⬆️
compiler/native/validate.go 96.42% <85.00%> (-3.58%) ⬇️
compiler/native/parse.go 83.63% <100.00%> (ø)
compiler/template/native/render.go 86.95% <100.00%> (ø)
... and 1 more

jbrockopp
jbrockopp previously approved these changes Mar 11, 2022
Copy link
Contributor

@jbrockopp jbrockopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jbrockopp
jbrockopp previously approved these changes Mar 11, 2022
Copy link
Contributor

@jbrockopp jbrockopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jbrockopp
jbrockopp previously approved these changes Mar 11, 2022
Copy link
Contributor

@jbrockopp jbrockopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ecrupper
ecrupper previously approved these changes Mar 14, 2022
Copy link
Contributor

@ecrupper ecrupper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@JordanSussman JordanSussman dismissed stale reviews from ecrupper and jbrockopp via 28af1c7 March 15, 2022 20:14
Copy link
Contributor

@jbrockopp jbrockopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@wass3r wass3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants