Skip to content

Conversation

@kaymckay
Copy link
Contributor

@kaymckay kaymckay commented Mar 3, 2022

This PR adds the new golangci linter configuration and cleans the repo. Since there was a lot, I cleaned a1-2 linters per commit for better visibility of the changes.

some things to note:

  • noctx yelled at not having contexts with requests, so context.background() was added
  • middleware/token.go uses a deprecated StandardClaims which is currently linted as a false positive, but we may want to upgrade to RegisterClaims -> causes some typing issues
    • will make an issue for this
  • removed changelog code

@codecov
Copy link

codecov bot commented Mar 3, 2022

Codecov Report

Merging #605 (e8cd089) into master (01cf76c) will increase coverage by 0.05%.
The diff coverage is 26.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #605      +/-   ##
==========================================
+ Coverage   54.35%   54.40%   +0.05%     
==========================================
  Files         181      181              
  Lines       15169    15180      +11     
==========================================
+ Hits         8245     8259      +14     
+ Misses       6607     6604       -3     
  Partials      317      317              
Impacted Files Coverage Δ
api/authenticate.go 0.00% <ø> (ø)
api/build.go 1.85% <0.00%> (+0.02%) ⬆️
api/deployment.go 0.00% <0.00%> (ø)
api/hook.go 0.00% <ø> (ø)
api/log.go 0.00% <0.00%> (ø)
api/metrics.go 0.00% <0.00%> (ø)
api/pagination.go 0.00% <ø> (ø)
api/pipeline.go 0.00% <0.00%> (ø)
api/repo.go 0.00% <ø> (ø)
api/scm.go 0.00% <0.00%> (ø)
... and 71 more

@kaymckay kaymckay requested review from a team and kneal March 3, 2022 16:48
@kaymckay kaymckay marked this pull request as ready for review March 3, 2022 16:51
@kaymckay kaymckay closed this Mar 3, 2022
@kaymckay kaymckay reopened this Mar 3, 2022
KellyMerrick
KellyMerrick previously approved these changes Mar 7, 2022
Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kaymckay kaymckay requested a review from a team March 8, 2022 13:30
Copy link
Collaborator

@wass3r wass3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor comments - let me know what you think. thanks for all the work!

Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants