-
Notifications
You must be signed in to change notification settings - Fork 30
chore: Update golangci-linter config and clean repo #605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #605 +/- ##
==========================================
+ Coverage 54.35% 54.40% +0.05%
==========================================
Files 181 181
Lines 15169 15180 +11
==========================================
+ Hits 8245 8259 +14
+ Misses 6607 6604 -3
Partials 317 317
|
KellyMerrick
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
wass3r
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some minor comments - let me know what you think. thanks for all the work!
KellyMerrick
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This PR adds the new golangci linter configuration and cleans the repo. Since there was a lot, I cleaned a1-2 linters per commit for better visibility of the changes.
some things to note: