feat(api/repo): add ability to sort by latest #611
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #611 +/- ##
==========================================
+ Coverage 55.06% 55.07% +0.01%
==========================================
Files 194 194
Lines 15704 15728 +24
==========================================
+ Hits 8647 8662 +15
- Misses 6697 6704 +7
- Partials 360 362 +2
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
cognifloyd
previously approved these changes
Apr 5, 2022
Member
cognifloyd
left a comment
cognifloyd
left a comment
There was a problem hiding this comment.
LGTM.
I'm not sure what you can do (if anything) about Github's "Code scanning" warning: "Database query built from user-controlled sources" since that's how it was before.
wass3r
reviewed
Apr 20, 2022
Collaborator
wass3r
left a comment
wass3r
left a comment
There was a problem hiding this comment.
super minor suggestion. otherwise, looks good
| // name: sort_by | ||
| // description: How to sort the results | ||
| // type: string | ||
| // default: name |
Collaborator
There was a problem hiding this comment.
should we add enum here? it can really only be name or latest right?
see example here:
Lines 43 to 46 in 61358d2
wass3r
approved these changes
Apr 21, 2022
cognifloyd
approved these changes
Apr 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the effort for go-vela/community#343
GetOrgReposfunction:sort_by