Skip to content

Conversation

@dtanner
Copy link
Contributor

@dtanner dtanner commented Mar 24, 2022

@codecov
Copy link

codecov bot commented Mar 24, 2022

Codecov Report

Merging #619 (0f4cacb) into master (11d7429) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #619   +/-   ##
=======================================
  Coverage   55.09%   55.09%           
=======================================
  Files         195      195           
  Lines       15723    15723           
=======================================
  Hits         8663     8663           
  Misses       6699     6699           
  Partials      361      361           
Impacted Files Coverage Δ
compiler/native/environment.go 82.54% <100.00%> (ø)

@dtanner dtanner force-pushed the feature/rename_ci_env branch from 7be839c to ebd8c4d Compare March 24, 2022 17:57
@wass3r wass3r changed the title modify CI environment value to true enhance!: modify CI environment value to true Mar 24, 2022
cognifloyd
cognifloyd previously approved these changes Apr 5, 2022
Copy link
Member

@cognifloyd cognifloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a minor nit, but otherwise LGTM.

wass3r
wass3r previously approved these changes Apr 8, 2022
@dtanner dtanner dismissed stale reviews from wass3r and cognifloyd via 0666b61 April 12, 2022 18:30
@dtanner dtanner force-pushed the feature/rename_ci_env branch from 36028bd to 0666b61 Compare April 12, 2022 18:30
Copy link
Contributor

@ecrupper ecrupper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wass3r wass3r merged commit cb09250 into master Apr 12, 2022
@wass3r wass3r deleted the feature/rename_ci_env branch April 12, 2022 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants