Skip to content

Conversation

@ecrupper
Copy link
Contributor

Part of the effort for go-vela/community#459

Includes:

Why is this a draft?

  • Currently using non-versioned instance of the go-github library. Will update to latest version when they release it.

Things to note:

  • It is necessary that whichever users adopt this have a version of GitHub that is 3.2 or higher. Otherwise, there will be 415 errors when trying to execute. I added some error handling for that in this PR.

@ecrupper ecrupper added the feature Indicates a new feature label Mar 29, 2022
@ecrupper ecrupper requested a review from a team as a code owner March 29, 2022 19:05
@ecrupper ecrupper self-assigned this Mar 29, 2022
@codecov
Copy link

codecov bot commented Mar 29, 2022

Codecov Report

Merging #622 (f1f268e) into master (5b0c408) will decrease coverage by 0.13%.
The diff coverage is 31.03%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #622      +/-   ##
==========================================
- Coverage   55.48%   55.34%   -0.14%     
==========================================
  Files         195      195              
  Lines       15749    15836      +87     
==========================================
+ Hits         8738     8765      +27     
- Misses       6646     6702      +56     
- Partials      365      369       +4     
Impacted Files Coverage Δ
api/hook.go 0.00% <0.00%> (ø)
compiler/registry/github/github.go 100.00% <ø> (ø)
compiler/registry/github/template.go 58.53% <ø> (ø)
scm/github/access.go 95.28% <ø> (ø)
scm/github/authentication.go 80.95% <ø> (ø)
scm/github/changeset.go 87.03% <ø> (ø)
scm/github/deployment.go 87.74% <ø> (ø)
scm/github/github.go 100.00% <ø> (ø)
scm/github/repo.go 73.89% <ø> (ø)
scm/github/webhook.go 87.25% <62.79%> (-2.95%) ⬇️

@ecrupper ecrupper marked this pull request as draft March 29, 2022 19:16
@ecrupper ecrupper marked this pull request as ready for review May 2, 2022 15:39
Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Indicates a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants