Skip to content

Conversation

@jbrockopp
Copy link
Contributor

@jbrockopp jbrockopp commented Apr 20, 2022

Dependent on #574 and #626

Part of the effort for go-vela/community#460

This adds support for the pipelines resource to the github.com/go-vela/server/router/middleware package.

This follows the exact same pattern and strategy for how we've added middleware support for other resources.

This will be used inside of #615 which adds API CRUD support for pipelines.

I've pulled this logic out into a separate PR to improve the experience when reviewing the code.

@jbrockopp jbrockopp added the feature Indicates a new feature label Apr 20, 2022
@jbrockopp jbrockopp self-assigned this Apr 20, 2022
@jbrockopp jbrockopp marked this pull request as ready for review April 20, 2022 15:22
@jbrockopp jbrockopp requested a review from a team as a code owner April 20, 2022 15:22
@codecov
Copy link

codecov bot commented Apr 20, 2022

Codecov Report

Merging #627 (62cf15d) into master (d8f169f) will increase coverage by 0.15%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #627      +/-   ##
==========================================
+ Coverage   55.07%   55.22%   +0.15%     
==========================================
  Files         194      196       +2     
  Lines       15728    15781      +53     
==========================================
+ Hits         8662     8715      +53     
  Misses       6704     6704              
  Partials      362      362              
Impacted Files Coverage Δ
router/middleware/pipeline/context.go 100.00% <100.00%> (ø)
router/middleware/pipeline/pipeline.go 100.00% <100.00%> (ø)

Copy link
Member

@cognifloyd cognifloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is WIP... Here's a quick comment from my early review.

@wass3r wass3r merged commit ccfff2a into master Apr 22, 2022
@wass3r wass3r deleted the feature/middleware/pipeline branch April 22, 2022 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Indicates a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants