-
Notifications
You must be signed in to change notification settings - Fork 30
feat(middleware): add support for pipelines #627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #627 +/- ##
==========================================
+ Coverage 55.07% 55.22% +0.15%
==========================================
Files 194 196 +2
Lines 15728 15781 +53
==========================================
+ Hits 8662 8715 +53
Misses 6704 6704
Partials 362 362
|
cognifloyd
reviewed
Apr 20, 2022
Member
cognifloyd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is WIP... Here's a quick comment from my early review.
cognifloyd
approved these changes
Apr 20, 2022
wass3r
approved these changes
Apr 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependent on #574 and #626
Part of the effort for go-vela/community#460
This adds support for the
pipelinesresource to thegithub.amrom.workers.dev/go-vela/server/router/middlewarepackage.This follows the exact same pattern and strategy for how we've added
middlewaresupport for other resources.This will be used inside of #615 which adds API CRUD support for
pipelines.I've pulled this logic out into a separate PR to improve the experience when reviewing the code.