feat(compiler/database/scm)!: add event action build field and use for rulesets #630
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #630 +/- ##
=======================================
Coverage 55.47% 55.48%
=======================================
Files 195 195
Lines 15740 15749 +9
=======================================
+ Hits 8732 8738 +6
- Misses 6644 6646 +2
- Partials 364 365 +1
|
cognifloyd
reviewed
Apr 26, 2022
Member
cognifloyd
left a comment
cognifloyd
left a comment
There was a problem hiding this comment.
I have a question about restricting the PR edited event. Otherwise this looks good
scm/github/webhook.go
Outdated
Comment on lines
187
to
193
| // if the edits to the PR are not related to the title or base branch, ignore them | ||
| if strings.EqualFold(payload.GetAction(), "edited") { | ||
| title := payload.GetChanges().GetTitle() | ||
| base := payload.GetChanges().GetBase() | ||
|
|
||
| if title == nil && base == nil { | ||
| return &types.Webhook{Hook: h}, nil |
Member
There was a problem hiding this comment.
Why? What if someone had a workflow that validated the PR description followed some format, would we not support that?
cognifloyd
previously approved these changes
Apr 27, 2022
Collaborator
|
conflicts :( |
cognifloyd
approved these changes
Apr 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the effort of go-vela/community#159
PR accomplishes the following:
scm/github/webhook.goif the event ispull_requestorcomment. Otherwise, this field remainsnil.nil, to create a scoped<event>:<action>combination to utilize for determining whether or not a step should execute. There will be a separate PR to address this at runtime in the worker code.event_actionfield to the ddl